This repository was archived by the owner on Aug 3, 2020. It is now read-only.
link libpcrecpp before other libraries#108
Merged
Merged
Conversation
Contributor
Author
|
we need either #108 or #107, I'm afraid that #108 may not effective if something has changed, #107 seems more robust for this type of issue. but at this moment changing robot_model is very riskey so we should choose #107 for indigo and #108 for jade or k-turtle, I used this launch file for testing. |
Contributor
Author
|
@isucan I think we can merge this PR (and release this before next indigo release is out) , which is just changes the order of link libraries. |
isucan
added a commit
that referenced
this pull request
May 2, 2015
link libpcrecpp before other libraries
Contributor
|
Merged, but this is very fragile indeed |
Contributor
Author
|
thanks! |
8 tasks
Closed
This was referenced Jun 18, 2015
isucan
added a commit
that referenced
this pull request
Jul 15, 2015
pazeshun
added a commit
to pazeshun/rtmros_common
that referenced
this pull request
Nov 9, 2019
pazeshun
added a commit
to pazeshun/rtmros_common
that referenced
this pull request
Nov 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #106 was not perfect, we need to link pcrecpp before othre libraries