Skip to content
This repository was archived by the owner on Aug 3, 2020. It is now read-only.

link libpcrecpp before other libraries#108

Merged
isucan merged 1 commit into
ros:indigo-develfrom
k-okada:fix_pcrecpp2
May 2, 2015
Merged

link libpcrecpp before other libraries#108
isucan merged 1 commit into
ros:indigo-develfrom
k-okada:fix_pcrecpp2

Conversation

@k-okada
Copy link
Copy Markdown
Contributor

@k-okada k-okada commented Apr 28, 2015

fix #106 was not perfect, we need to link pcrecpp before othre libraries

@k-okada
Copy link
Copy Markdown
Contributor Author

k-okada commented Apr 28, 2015

we need either #108 or #107, I'm afraid that #108 may not effective if something has changed, #107 seems more robust for this type of issue. but at this moment changing robot_model is very riskey so we should choose #107 for indigo and #108 for jade or k-turtle,

I used this launch file for testing.

<launch>
  <!-- sudo apt-get install ros-hydro-openhrp3 -->
  <arg name="COLLADA_FILE" value="/opt/ros/indigo/share/OpenHRP-3.1/sample/model/PA10/pa10.main.dae" />
  <param name="robot_description" textfile="$(arg COLLADA_FILE)" />
  <node pkg="robot_state_publisher" type="state_publisher" name="hrpsys_state_publisher" />
</launch>

@k-okada
Copy link
Copy Markdown
Contributor Author

k-okada commented May 2, 2015

@isucan I think we can merge this PR (and release this before next indigo release is out) , which is just changes the order of link libraries.

isucan added a commit that referenced this pull request May 2, 2015
link libpcrecpp before other libraries
@isucan isucan merged commit 6534424 into ros:indigo-devel May 2, 2015
@isucan
Copy link
Copy Markdown
Contributor

isucan commented May 2, 2015

Merged, but this is very fragile indeed

@k-okada
Copy link
Copy Markdown
Contributor Author

k-okada commented May 2, 2015

thanks!

@k-okada k-okada deleted the fix_pcrecpp2 branch May 2, 2015 16:17
@130s 130s mentioned this pull request May 30, 2015
isucan added a commit that referenced this pull request Jul 15, 2015
pazeshun added a commit to pazeshun/rtmros_common that referenced this pull request Nov 9, 2019
pazeshun added a commit to pazeshun/rtmros_common that referenced this pull request Nov 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants